fix: add buffer-length check in nvme-print.c#3407
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
Multiple sprintf calls in nvme-print Signed-off-by: orbisai0security <mediratta01.pally@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
nvme-print.c.Vulnerability
V-001nvme-print.c:224Description: Multiple sprintf calls in nvme-print.c write formatted output into fixed-size stack buffers without bounds checking. The function pel_event_to_string(type) returns a string whose length is not validated before being formatted with sprintf. If a malicious NVMe device returns unexpected event type values, the resulting formatted string could exceed the buffer size, causing a stack-based buffer overflow that could enable arbitrary code execution.
Evidence
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Threat Model Context
This is a Python library - vulnerabilities affect applications that import this code.
Changes
nvme-print.cVerification
Security Invariant
Regression test
This test guards against regressions — it's useful independent of the code change above.
Automated security fix by OrbisAI Security