feat: set window title for launcher popup#742
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Mar 19, 2026
Merged
Conversation
1. Added windowTitle property to launcher popup window to help KWin distinguish it from other popup windows 2. Updated debian/control to add dde-shell dependency (version > 2.0.33) to ensure compatibility with the window title feature Log: Set window title for launcher popup to improve window management Influence: 1. Test launcher popup opening and closing functionality 2. Verify window title appears correctly in window manager 3. Check that launcher can be distinguished from other popup windows in KWin 4. Test compatibility with different DDE shell versions 5. Verify launcher positioning and behavior remains unchanged feat: 为启动器弹窗设置窗口标题 1. 为启动器弹窗窗口添加 windowTitle 属性，帮助 KWin 区分其他弹窗窗口 2. 更新 debian/control 添加 dde-shell 依赖（版本 > 2.0.33）以确保窗口标 题功能的兼容性 Log: 为启动器弹窗设置窗口标题以改进窗口管理 Influence: 1. 测试启动器弹窗的打开和关闭功能 2. 验证窗口标题在窗口管理器中正确显示 3. 检查启动器在 KWin 中是否能与其他弹窗窗口区分开来 4. 测试与不同 DDE shell 版本的兼容性 5. 验证启动器定位和行为保持不变
18202781743
requested review from
BLumia,
fly602,
mhduiy,
robertkill,
wjyrich and
yixinshark
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSets an explicit window title on the launcher popup QML window so KWin and other window managers can distinguish it from other popups, and updates Debian packaging to require a dde-shell version that supports this behavior. Sequence diagram for launcher popup showing with explicit windowTitlesequenceDiagram
actor User
participant LauncherApplet
participant LauncherPopupWindow
participant WindowManager_KWin
User->>LauncherApplet: triggerLauncher()
LauncherApplet->>LauncherPopupWindow: openPopup()
LauncherPopupWindow->>LauncherPopupWindow: set windowTitle dde-shell/launchpad
LauncherPopupWindow->>WindowManager_KWin: createWindow(windowTitle)
WindowManager_KWin->>WindowManager_KWin: classifyWindowByTitle()
WindowManager_KWin-->>User: display popup as launcher window
User->>LauncherApplet: closeLauncher()
LauncherApplet->>LauncherPopupWindow: closePopup()
LauncherPopupWindow->>WindowManager_KWin: destroyWindow()
Class diagram for launcher popup QML window with windowTitle propertyclassDiagram
class LauncherItem {
int width
int height
// other existing properties
}
class LauncherPopupWindow {
int width
int height
string windowTitle
int popupX
int popupY
}
LauncherItem "1" *-- "1" LauncherPopupWindow : contains
class DockPanelPositioner {
int x
int y
rect bounding
}
LauncherPopupWindow --> DockPanelPositioner : positions popup
class Panel {
static int position
}
Panel <.. DockPanelPositioner : provides position context
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider defining the window title string ("dde-shell/launchpad") as a shared constant or central configuration so it can be reused consistently by other components or future popups that need to be distinguished by KWin.
- If the debian/control change uses a strict "> 2.0.33" version constraint as described, you may want to switch to ">= 2.0.33" to avoid unnecessarily excluding builds that exactly match 2.0.33 while still guaranteeing compatibility.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider defining the window title string ("dde-shell/launchpad") as a shared constant or central configuration so it can be reused consistently by other components or future popups that need to be distinguished by KWin.
- If the debian/control change uses a strict "> 2.0.33" version constraint as described, you may want to switch to ">= 2.0.33" to avoid unnecessarily excluding builds that exactly match 2.0.33 while still guaranteeing compatibility.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review这段代码的 diff 包含了两个文件的修改： 1. 文件：
|
BLumia
approved these changes
Mar 19, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
distinguish it from other popup windows
to ensure compatibility with the window title feature
Log: Set window title for launcher popup to improve window management
Influence:
in KWin
feat: 为启动器弹窗设置窗口标题
题功能的兼容性
Log: 为启动器弹窗设置窗口标题以改进窗口管理
Influence:
Summary by Sourcery
Set a distinct window title for the launcher popup and bump the dde-shell dependency to ensure compatibility with this behavior.
New Features:
Build: