feat(bindings): expose AVAudioFifo data path and av_tx FFT call#52
Merged
Conversation
flexiondotorg
commented
Jun 8, 2026
flexiondotorg
commented
Contributor
- Add AVAudioFifoWrite, AVAudioFifoRead, AVAudioFifoPeek, AVAudioFifoPeekAt wrappers reusing samplePointerArray from samples.go for planar/packed audio
- Add AVTxCall invoker shim (tx.c + tx.go) to call av_tx function pointers from Go, enabling FFT transform invocation on AVTXContext
- Both APIs remain root-package only; skip accounting confirmed at ceiling 245
- Add AVAudioFifoWrite, AVAudioFifoRead, AVAudioFifoPeek, AVAudioFifoPeekAt wrappers reusing samplePointerArray from samples.go for planar/packed audio - Add AVTxCall invoker shim (tx.c + tx.go) to call av_tx function pointers from Go, enabling FFT transform invocation on AVTXContext - Both APIs remain root-package only; skip accounting confirmed at ceiling 245 Signed-off-by: Martin Wimpress <code@wimpress.io>
- Add audio_fifo.go and tx.go entries to hand-written bindings section - Update coverage from 89.9% to 90.4% (911/1008 functions) Signed-off-by: Martin Wimpress <code@wimpress.io>
Signed-off-by: Martin Wimpress <code@wimpress.io>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
0 issues found across 4 files (changes from recent commits).
Requires human review: These new C bindings for audio FIFO and FFT function pointers involve unsafe C interop and memory management, adding significant complexity and risk that warrants a human review despite passing an AI check.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
Review completed
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: This PR adds low-level cgo bindings to FFmpeg's audio FIFO and FFT transform APIs, using unsafe.Pointer and C function pointers; such changes have inherent memory-safety risks and require careful human review beyond what automated analysis can catch.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.