feat(cli): make --episode flag optional#51
Merged
Merged
Conversation
When --episode is omitted, no episode number is rendered on the overlay. When supplied, behaviour remains unchanged. Implements optional podcast metadata field with nil-guard in rendering pipeline. Closes #31 Signed-off-by: Martin Wimpress <code@wimpress.io>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 4 files
Confidence score: 4/5
- This PR looks safe to merge overall, with one moderate behavior mismatch rather than a broad stability risk.
- In
internal/renderer/frame.go, an explicit--episode=0is currently rendered as00, which conflicts with the documented output requirement of0when the flag is present. - Given the issue’s medium severity (5/10) and localized scope, risk appears limited to formatting/output correctness for this flag path.
- Pay close attention to
internal/renderer/frame.go- ensure explicit--episode=0formatting matches the documented0behavior.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When --episode is omitted, no episode number is rendered on the overlay. When supplied, behaviour remains unchanged. Implements optional podcast metadata field with nil-guard in rendering pipeline.
Closes #31