Remove previous track actors from coverBox#13648
Open
Alpha-404 wants to merge 2 commits intolinuxmint:masterfrom
Open
Remove previous track actors from coverBox#13648Alpha-404 wants to merge 2 commits intolinuxmint:masterfrom
Alpha-404 wants to merge 2 commits intolinuxmint:masterfrom
Conversation
Fix bug where previous tracks render under current track.
Member
|
Hi, why are actors accumulating this way? That's the bug we need to fix, not just clean up after it. |
Refactor cover image handling in the sound applet.
Author
|
Ah, it was _showCover silently failing when it thinks a track has no cover art (probably another issue then, as i only found this issue by using tracks with cover art), causing them to pile up because it never swapped it out in coverBox after setting St.Icon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug where previous tracks render under current track.
This bug is visible when you play a couple tracks on something like soundcloud (with thumbnails), open the sound applet, then when closing it, the previous tracks thumbnail would be visible when fading out the current tracks thumbnail on the close animation