Add PopupDialog widget - draggable, re-focusable dialog.#13658
Add PopupDialog widget - draggable, re-focusable dialog.#13658mtwebster wants to merge 5 commits intolinuxmint:masterfrom
Conversation
- baseDialog.js: adds a base class for shared code between modal and popup dialog. - popupDialog.js: Draggable wrapper for Dialog.Dialog, to use in place of ModalDialog. - The 'popup-dialog' css class can be used to help differeniation. In the default theme, there's a faint box shadow that uses the accent color. ref: https://github.com/orgs/linuxmint/discussions/774
This is nice to have now with dialogs not being permanently-focused.
A popup dialog may be visible, and may have been added after the modal (the RunDialog doesn't get destroyed once instantiated).
Best-practices scannerThis is a regex-based check for API usage that can pose security, performance or This check is not perfect will not replace a normal review.Found 3 potential issue(s):
|
during a drag, handle failed grab.
Best-practices scannerThis is a regex-based check for API usage that can pose security, performance or This check is not perfect will not replace a normal review.Found 3 potential issue(s):
|
and popup dialog.
place of ModalDialog.
In the default theme, there's a faint box shadow that uses the
accent color.
ref:
https://github.com/orgs/linuxmint/discussions/774