feat(migrations): support specifying schema for migrations#471
Draft
cofin wants to merge 8 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
==========================================
+ Coverage 70.78% 71.02% +0.24%
==========================================
Files 438 438
Lines 52541 52829 +288
Branches 7370 7408 +38
==========================================
+ Hits 37189 37524 +335
+ Misses 12682 12656 -26
+ Partials 2670 2649 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ec9e0c8 to
b9d3ad2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default_schemaand tracker schema resolution through migration config, commands, runners, and utilities.SyncMigrationTracker; remove the custom adapter tracker path.PRIMARY KEY NOT ENFORCEDand ordersDEFAULTbeforeNOT NULL.DEFAULTvalues in tracker DDL.Validation
make installmake lintmake test(7960 passed, 256 skipped)uv run pytest tests/unit/adapters/test_bigquery/test_migration_schema.py tests/unit/adapters/test_oracledb/test_migration_schema.py -q(8 passed)env SQLSPEC_ENABLE_BIGQUERY_TESTS=1 uv run pytest tests/integration/adapters/bigquery/test_migrations.py -q --run-bigquery-tests(1 passed, 3 skipped on emulator)make coveragewas attempted aftermake test; it produced broad integration failures and then hung during teardown, so I terminated it without a final coverage report.