Cache download-files in Dockerfile and simplify the download-files script#49
Open
aryeila wants to merge 2 commits into
Open
Cache download-files in Dockerfile and simplify the download-files script#49aryeila wants to merge 2 commits into
aryeila wants to merge 2 commits into
Conversation
aryeila
requested review from
Topherhindman,
bcherry,
kath0la,
rektdeckard and
royalfig
bcherry
reviewed
May 28, 2026
Contributor
|
@aryeila did you test this by deploying to cloud? |
Contributor
Author
yes! & just double checked with a redeploy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Two related cleanups around
download-files:download-filesstep beforeCOPY . .so the download layer caches across code-only changes — editing your agent no longer triggers a re-download of plugin model files.pnpm run build &&prefix from thedownload-filesscript. The standalonenpx livekit-agents download-filescommand (already referenced by this script) discovers installed@livekit/agents-plugin-*packages without loading your agent code, so the build step before it was a no-op.Changes
Dockerfile—RUN pnpm download-filesmoved beforeCOPY . .(was previously betweenpnpm buildandpnpm prune --prod).package.json—"download-files": "pnpm run build && npx livekit-agents download-files"→"download-files": "npx livekit-agents download-files".@livekit/agentsis pinned at^1.4.3, which is the version that introduced the standalonelivekit-agents download-filesCLI.Related PRs
This is part of a coordinated rollout across five repos. Each PR updates one slice of the same migration.
Upstream SDK changes: