fix(voice): align session.start recording with Python primary-session semantics#1704
Merged
Merged
Conversation
… semantics Move the primary/secondary AgentSession designation into start() before initRecording so a demoted secondary session never configures cloud recording. A non-primary session whose `record` was not explicitly given now silently disables recording instead of throwing; it only throws when `record` was passed explicitly, mirroring Python's record_is_given logic. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: e570c88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e570c889f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
theomonnom
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1702 (granular
RecordingOptions). That PR ported the recording-options model but left the primary-session designation out of parity with the Python SDK. This aligns it:AgentSessiondesignation now happens instart()beforeinitRecording, so a demoted secondary session never configures cloud recording. (Previously the designation lived in_startImpl, which runs afterstart()already calledinitRecording.)recordwas not explicitly given now silently disables its recording, instead of throwing. It still throws only whenrecordwas passed explicitly — mirroring Python'srecord_is_givenlogic inagent_session.py:629-655.ctx._primaryAgentSession === thisre-entry case to match Python'sis None or is self.Why this matters
recorddefaults to the server-sidejob.enableRecording(oftentrue). Before this change, a secondAgentSessionin the same job would throw onstart()even though the user never asked to record it. Python avoids this by auto-disabling the secondary session; this PR brings JS to parity.Test plan
Verified end-to-end by driving a real agent through
agents-cliagainst LiveKit Cloud (voice mode), with temporary instrumentation on every recording gate. Confirmed via runtime logs:recordaudio.ogg)truefalse{audio-only}{transcript-only}pnpm build:agentspassesagent_sessionunit tests pass