fix: return error to LLM for unknown function calls in voice path#4938
Open
rupesh-svg wants to merge 1 commit intolivekit:mainfrom
Open
fix: return error to LLM for unknown function calls in voice path#4938rupesh-svg wants to merge 1 commit intolivekit:mainfrom
rupesh-svg wants to merge 1 commit intolivekit:mainfrom
Conversation
When the LLM calls a function not registered in the tool context, the voice path silently skips it with `continue`, leaving tool_output.output empty. This causes the agent to stop responding entirely since the downstream code in agent_activity.py only retriggers the LLM when tool outputs are present. Return a FunctionCallResult with is_error=True (via make_tool_output) so the LLM receives the error and can recover gracefully. This matches the existing behavior in llm/utils.py and the validation error handler already present in the same function. Fixes livekit#4933
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4933
The voice path in
generation.pysilently drops unknown function calls withcontinue, leavingtool_output.outputempty. This causes the agent to stop responding sinceagent_activity.pyonly retriggers the LLM when tool outputs are present.Now returns a
FunctionCallResultwithis_error=Trueviamake_tool_output, matching the existing pattern inllm/utils.pyand the validation error handler in the same function.