Fix/sarvam tts update options language code#4957
Open
yusuf-eren wants to merge 2 commits intolivekit:mainfrom
Open
Fix/sarvam tts update options language code#4957yusuf-eren wants to merge 2 commits intolivekit:mainfrom
yusuf-eren wants to merge 2 commits intolivekit:mainfrom
Conversation
yusuf-eren
force-pushed
the
fix/sarvam-tts-update-options-language-code
branch
from
5e79b39 to
9b31f07
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…s and remove duplicate option assignments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target_language_codeparameter toTTS.update_options()in the Sarvam plugin, with empty-string validation consistent with the constructor.Fix
The constructor accepts
target_language_codebutupdate_options()did not, making it impossible to switch the TTS language mid-session without accessing private attributes.