Stop audio publishing when audio session activation fails#808
Merged
hiroshihorie merged 3 commits intomainfrom Mar 24, 2026
Merged
Stop audio publishing when audio session activation fails#808hiroshihorie merged 3 commits intomainfrom
hiroshihorie merged 3 commits intomainfrom
Conversation
|
|
This was referenced Mar 16, 2026
Closed
hiroshihorie
force-pushed
the
hiroshi/audio-session-activate-check
branch
4 times, most recently
from
2bbeb06 to
12dbd0c
Compare
hiroshihorie
force-pushed
the
hiroshi/audio-session-activate-check
branch
from
12dbd0c to
c20bcb0
Compare
pblazej
reviewed
Mar 17, 2026
pblazej
reviewed
Mar 17, 2026
Contributor
pblazej
left a comment
pblazej
left a comment
There was a problem hiding this comment.
I haven't encountered a crash on main, but that's definitely a step in the right direction 💯
Left 1 comment worth fixing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More audio safety checks
How to test: try to publish when Siri or Phone call is active.