Platform audio for Unity#293
Open
MaxHeimbrock wants to merge 4 commits into
Open
Conversation
MaxHeimbrock
force-pushed
the
max/final-platform-audio
branch
from
149fad2 to
e88ff05
Compare
MaxHeimbrock
changed the title
MaxHeimbrock
force-pushed
the
max/final-platform-audio
branch
from
9bd2f8c to
0f2ee14
Compare
MaxHeimbrock
commented
Jun 9, 2026
|
|
||
| /// <summary> | ||
| /// Sets the recording device (microphone) by index. | ||
| /// |
Contributor
Author
There was a problem hiding this comment.
Add disclaimer here as well about mobile platform no-ops
MaxHeimbrock
commented
Jun 9, 2026
| /// platformAudio.Dispose(); | ||
| /// </code> | ||
| /// </example> | ||
| public sealed class PlatformAudio : IDisposable |
Contributor
Author
There was a problem hiding this comment.
Maybe add a Rust side function call for PlatformAudio.DeviceSelectionSupported for clients to query.
Contributor
Author
There was a problem hiding this comment.
If we do support device selection on mobile in the future, the client code does not change.
Contributor
Author
There was a problem hiding this comment.
Split between input and output device selection?
MaxHeimbrock
commented
Jun 9, 2026
| foreach (var device in playout) | ||
| Debug.Log($" [{device.Index}] {device.Name}"); | ||
|
|
||
| if (_platformAudio.RecordingDeviceCount > 0) |
Contributor
Author
There was a problem hiding this comment.
Test with a device that has no input or output device
Contributor
Author
|
Add tests to init platform audio. |
Contributor
Author
Look at the cpp side: |
Mirror the C++ PlatformAudio test suites in the Unity Test Framework: - EditMode (pure-managed, always run): AudioProcessingOptions defaults, AudioDevice struct, PlatformAudioSource null-arg guard. - PlayMode unit (ADM-backed, no server): create source/track, custom options, enumerate + select-by-GUID, out-of-range index, start/stop recording. Skips via Assert.Ignore when no platform ADM is available. - PlayMode E2E (Category=E2E): publish/unpublish round-trip, multiple sources from one manager, and media flow verified via an InboundRtp audio stat (the batch-mode-friendly substitute for the C++ frame callback). Shared PlatformAudioTestHelper.TryCreateOrIgnore mirrors GTEST_SKIP for environments without an ADM. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Integrates the Rust Platform Audio Module. The old Unity audio input and output is still supported, the platform audio is now a second path to get audio input and output.
Changes