Skip to content

Use Utils logging helpers instead of raw Debug.Log in SDK runtime #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxHeimbrock merged 1 commit into from
Jun 10, 2026
+6 −5
Merged

Use Utils logging helpers instead of raw Debug.Log in SDK runtime #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Runtime/Scripts/Rpc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using System;
using System.Collections.Generic;
using UnityEngine;
using LiveKit.Internal;

namespace LiveKit
{
Expand Down Expand Up @@ -90,7 +90,7 @@ public RpcError(uint code, string message, string rpcData = null) : base(message

internal static RpcError FromProto(Proto.RpcError proto)
{
Debug.Log($"RPC error received: {proto.Code} {proto.Message} {proto.Data}");
Utils.Debug($"RPC error received: {proto.Code} {proto.Message} {proto.Data}");
return new RpcError(proto.Code, proto.Message, proto.Data);
}

Expand Down
2 changes: 1 addition & 1 deletion Runtime/Scripts/RtcAudioSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ protected RtcAudioSource(int channels = 2, RtcAudioSourceType audioSourceType =
DefaultMicrophoneSampleRate : DefaultSampleRate;
_expectedSampleRate = newAudioSource.SampleRate;

UnityEngine.Debug.Log($"NewAudioSource: {newAudioSource.NumChannels} {newAudioSource.SampleRate}");
Utils.Debug($"NewAudioSource: {newAudioSource.NumChannels} {newAudioSource.SampleRate}");

newAudioSource.Options = request.TempResource<AudioSourceOptions>();
newAudioSource.Options.EchoCancellation = true;
Expand Down
2 changes: 1 addition & 1 deletion Runtime/Scripts/RtcVideoSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ protected virtual void Dispose(bool disposing)
UnityEngine.Object.Destroy(_previewTexture);
if (_captureBuffer.IsCreated)
{
Debug.Log("Disposing capture buffer");
Utils.Debug("Disposing capture buffer");
_captureBuffer.Dispose();
}
Handle?.Dispose();
Expand Down
3 changes: 2 additions & 1 deletion Runtime/Scripts/TokenSource/TokenSourceComponent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System.Linq;
using System.Threading.Tasks;
using UnityEngine;
using LiveKit.Internal;

namespace LiveKit
{
Expand Down Expand Up @@ -67,7 +68,7 @@ public TaskYieldInstruction<ConnectionDetails> FetchConnectionDetails(TokenSourc

case ITokenSourceFixed fixedSource:
if (options != null)
Debug.LogWarning("TokenSourceComponent uses a fixed config, so fetch options are ignored.");
Utils.Warning("TokenSourceComponent uses a fixed config, so fetch options are ignored.");
task = fixedSource.FetchConnectionDetails();
break;

Expand Down
Loading