Open
Conversation
real-danm
requested review from
andrewnitu,
Copilot,
rektdeckard and
yoonsio
and removed request for
Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an Enterprise only feature.
This PR adds support for bring-your-own-container on cloud agents. Currently only supports docker daemon or an OCI image tarball from a
docker save.I did not want to exec out to try and use docker on the cli, so instead attempting to connect to the docker socket directly and also normalize the image name. This ended up requiring more changes than expected, but seems to be working pretty well in testing.
This supports both macos/linux and respects the
DOCKER_HOSTenv var, otherwise will look for standard docker installs.Uses crane library to push to cloud agent servers.
Other runtimes that have a Docker-compatible API, like podman, should be supported via setting the
DOCKER_HOSTenv var.NOTE: probably need some polish around the
lk a create --image xyzworkflow. if the push fails, there is a dangling agent record.