Explain why ca-certificates is required in the Node Dockerfile template#849
Open
aryeila wants to merge 3 commits into
Open
Explain why ca-certificates is required in the Node Dockerfile template#849aryeila wants to merge 3 commits into
aryeila wants to merge 3 commits into
Conversation
The previous comment ("enables TLS/SSL for securely fetching dependencies")
implied this is generic Docker hygiene that could be skipped to shave layers.
That framing is misleading: @livekit/rtc-node ships a native Rust core that
reads the system trust store via rustls-tls-native-roots, not Node's bundled
CA roots. node:22-slim doesn't ship /etc/ssl/certs/ca-certificates.crt, so
without ca-certificates Room.connect() fails with the misleading
"failed to retrieve region info" error.
Rewrite the in-template comment to name the cause so a developer trimming the
image knows the line is load-bearing. No functional change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the in-template
ca-certificatescomment inpkg/agentfs/examples/node.Dockerfileto explain why the line is load-bearing.node:22-slimdoesn't ship the system CA bundle, so Node agents on it fail with a misleadingfailed to retrieve region infoerror. The previous comment ("enables TLS/SSL for securely fetching dependencies") implied this was generic Docker hygiene that could be trimmed, and users were doing exactly that. Reproduced and verified end-to-end against a live LiveKit Cloud project.No functional change. Filed against DOCS-1454.
Related PRs
Same change applied across the docs partial and sibling repos so they stay aligned:
Dockerfileexamples/src/Dockerfile-example