Skip to content

fix: clear pending timeout in AudioSource.close() #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasIO merged 3 commits into from
Apr 7, 2026
+13 −0
Merged

fix: clear pending timeout in AudioSource.close() #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
679e18f
fix: clear pending timeout in AudioSource.close()
LautaroPetaccio Apr 1, 2026
d8529ea
chore: add changeset
LautaroPetaccio Apr 1, 2026
3c58cf8
fix: call release() in close() to unblock pending waitForPlayout()
LautaroPetaccio Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/neat-pens-yawn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@livekit/rtc-node': patch
---

Clear pending timeout in AudioSource.close() to prevent use-after-free
8 changes: 8 additions & 0 deletions packages/livekit-rtc/src/audio_source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,14 @@ export class AudioSource {
}

async close() {
// Clear any pending playout timeout so its callback doesn't fire after
// the handle is disposed, which would reference freed native state.
if (this.timeout) {
clearTimeout(this.timeout);
this.timeout = undefined;
}
// Resolve any pending waitForPlayout() promise so callers don't hang.
this.release();
this.ffiHandle.dispose();
this.closed = true;
}
Expand Down
Loading