Skip to content

Update dependency vitest to v4 [SECURITY] #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dependency vitest to v4 [SECURITY] #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"prettier": "^3.2.5",
"turbo": "^2.0.0",
"typescript": "5.8.2",
"vitest": "^3.0.0"
"vitest": "^4.0.0"
},
"workspaces": [
"examples/*",
Expand Down
2 changes: 1 addition & 1 deletion packages/livekit-rtc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"prettier": "^3.0.3",
"tsup": "^8.3.5",
"typescript": "5.8.2",
"vitest": "^3.0.0"
"vitest": "^4.0.0"
},
"engines": {
"node": ">= 18"
Expand Down
2 changes: 1 addition & 1 deletion packages/livekit-server-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"typedoc": "^0.28.0",
"typescript": "5.8.2",
"vite": "^5.2.9",
"vitest": "^3.0.0"
"vitest": "^4.0.0"
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Vitest v4 requires Vite >=6 but livekit-server-sdk still depends on Vite ^5.2.9

Vitest 4.x declares a peer dependency of vite: ^6.0.0 || ^7.0.0 || ^8.0.0, but packages/livekit-server-sdk/package.json:61 still has "vite": "^5.2.9" as a devDependency. The lockfile confirms vitest 4.1.7 is resolved with vite 5.4.21, which is outside the supported range. This peer dependency mismatch can cause test failures or subtle runtime incompatibilities, since vitest v4 may rely on Vite 6 APIs. Additionally, packages/livekit-server-sdk/vite.config.ts:5 imports defineConfig from 'vite' (not 'vitest/config'), so the test property in the config object won't be type-checked and may not be picked up correctly by vitest v4.

Prompt for agents 
The vitest v4 upgrade requires vite to also be updated from ^5.2.9 to ^6.0.0 in packages/livekit-server-sdk/package.json. Vitest 4.x peer-depends on vite ^6.0.0 || ^7.0.0 || ^8.0.0. After bumping vite, verify that vite.config.ts still works — you may want to change the import from 'vite' to 'vitest/config' in packages/livekit-server-sdk/vite.config.ts as well, so the test configuration property is properly typed.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

},
"engines": {
"node": ">=18"
Expand Down
Loading
Loading