update proto: add agent_dev proto for CLI hot reload IPC#597
Open
theomonnom wants to merge 2 commits intomainfrom
Open
update proto: add agent_dev proto for CLI hot reload IPC#597theomonnom wants to merge 2 commits intomainfrom
theomonnom wants to merge 2 commits intomainfrom
Conversation
| @@ -0,0 +1,33 @@ | |||
| # -*- coding: utf-8 -*- | |||
Contributor
There was a problem hiding this comment.
🟡 New agent_dev module not exported from agent_pb/__init__.py
The new agent_dev module was added to the agent_pb package but livekit-protocol/livekit/protocol/agent_pb/__init__.py was not updated to import it. The existing __init__.py only contains from . import agent_session. This means livekit.protocol.agent_pb.agent_dev is not accessible after importing the package — confirmed by running hasattr(livekit.protocol.agent_pb, 'agent_dev') which returns False. This is inconsistent with the established pattern where agent_session is explicitly imported in __init__.py.
Prompt for agents
The file livekit-protocol/livekit/protocol/agent_pb/__init__.py currently only contains:
from . import agent_session
It needs to be updated to also import the new agent_dev module:
from . import agent_session
from . import agent_dev
This follows the existing pattern where all submodules in a package are imported in __init__.py so they are accessible as attributes of the package when imported.
Was this helpful? React with 👍 or 👎 to provide feedback.
davidzhao
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.