Skip to content

Reduce per-call overhead for self-closing components #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SanderMuller wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Reduce per-call overhead for self-closing components #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b96d2b
Reduce per-call overhead for self-closing components
SanderMuller Mar 29, 2026
d31efff
Use function_exists() guard inside ensureRequired
ganyicz Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compiler/Compiler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ protected function compileComponentTag(ComponentNode $node, ComponentSource $sou
$functionName = ($this->manager->isFolding() ? '__' : '_') . $hash;
[$attributesArrayString, $boundKeysArrayString, $originalKeysArrayString] = $this->compileAttributes($node);

$output = '<' . '?php $__blaze->ensureRequired(\'' . $source->path . '\', $__blaze->compiledPath.\'/'. $hash . '.php\'); ?>' . "\n";
$output = '<' . '?php $__blaze->ensureRequired(\'' . $source->path . '\', $__blaze->compiledPath.\'/'. $hash . '.php\', \'' . $functionName . '\'); ?>' . "\n";

if ($node->selfClosing) {
$output .= '<' . '?php $__blaze->pushData(' . $attributesArrayString . '); ?>' . "\n";
Expand Down
14 changes: 5 additions & 9 deletions src/Runtime/BlazeRuntime.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ class BlazeRuntime
protected ?string $compiledPath = null;

protected array $paths = [];
protected array $required = [];
protected array $blazed = [];

protected array $dataStack = [];
Expand All @@ -39,11 +38,11 @@ public function __construct(
}

/**
* Compile a component if its source is newer than the cached output.
* Compile and require a component if its function is not yet defined.
*/
public function ensureRequired(string $path, string $compiledPath): void
public function ensureRequired(string $path, string $compiledPath, string $functionName): void
{
if (isset($this->required[$compiledPath])) {
if (function_exists($functionName)) {
return;
}

Expand All @@ -52,8 +51,6 @@ public function ensureRequired(string $path, string $compiledPath): void
}

require $compiledPath;

$this->required[$compiledPath] = true;
}

/**
Expand All @@ -77,10 +74,9 @@ public function resolve(string $component): string|false

$hash = Utils::hash($path);
$compiled = $this->getCompiledPath().'/'.$hash.'.php';
$functionName = '_'.$hash;

if (! isset($this->required[$path])) {
$this->ensureRequired($path, $compiled);
}
$this->ensureRequired($path, $compiled, $functionName);

return $hash;
}
Expand Down
5 changes: 5 additions & 0 deletions tests/ComparisonTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@
BLADE
));

test('aware nested', fn () => compare(<<<'BLADE'
<x-nested-aware type="number" />
BLADE
));

test('foldable aware', fn () => compare(<<<'BLADE'
<x-foldable.wrapper type="number">
<x-foldable.input-aware />
Expand Down
4 changes: 2 additions & 2 deletions tests/Compiler/CompilerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
$hash = Utils::hash($path);

expect($compiled->render())->toEqualCollapsingWhitespace(join('', [
'<?php $__blaze->ensureRequired(\''. $path .'\', $__blaze->compiledPath.\'/'. $hash .'.php\'); ?> ',
'<?php $__blaze->ensureRequired(\''. $path .'\', $__blaze->compiledPath.\'/'. $hash .'.php\', \'_'. $hash .'\'); ?> ',
'<?php $__blaze->pushData([\'type\' => \'text\',\'disabled\' => $disabled]); ?> ',
'<?php _'. $hash .'($__blaze, [\'type\' => \'text\',\'disabled\' => $disabled], [], [\'disabled\'], [], $__this ?? (isset($this) ? $this : null)); ?> ',
'<?php $__blaze->popData(); ?>',
Expand Down Expand Up @@ -42,7 +42,7 @@
$hash = Utils::hash($path);

expect($compiled->render())->toEqualCollapsingWhitespace(join('', [
'<?php $__blaze->ensureRequired(\''. $path .'\', $__blaze->compiledPath.\'/'. $hash .'.php\'); ?> ',
'<?php $__blaze->ensureRequired(\''. $path .'\', $__blaze->compiledPath.\'/'. $hash .'.php\', \'_'. $hash .'\'); ?> ',
'<?php if (isset($__slots'. $hash .')) { $__slotsStack'. $hash .'[] = $__slots'. $hash .'; } ?> ',
'<?php if (isset($__attrs'. $hash .')) { $__attrsStack'. $hash .'[] = $__attrs'. $hash .'; } ?> ',
'<?php $__attrs'. $hash .' = [\'class\' => \'mt-8\']; ?> ',
Expand Down
2 changes: 1 addition & 1 deletion tests/Memoizer/MemoizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
'<?php echo \Livewire\Blaze\Memoizer\Memo::get($blaze_memoized_key); ?>',
'<?php else : ?>',
'<?php ob_start(); ?>',
'<?php $__blaze->ensureRequired(\''. $path .'\', $__blaze->compiledPath.\'/'. $hash .'.php\'); ?> ',
'<?php $__blaze->ensureRequired(\''. $path .'\', $__blaze->compiledPath.\'/'. $hash .'.php\', \'_'. $hash .'\'); ?> ',
'<?php $__blaze->pushData([\'src\' => $user->avatar]); ?> ',
'<?php _'. $hash .'($__blaze, [\'src\' => $user->avatar], [], [\'src\'], [], $__this ?? (isset($this) ? $this : null)); ?> ',
'<?php $__blaze->popData(); ?>',
Expand Down
3 changes: 3 additions & 0 deletions tests/fixtures/views/components/nested-aware.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
@blaze

<x-input-aware />
Loading