Embed Prism dashboard in docs and fix missing sidebar item#280
Open
jjk-g wants to merge 2 commits into
Open
Conversation
jjk-g
requested review from
Gregory-Pereira,
chcost,
clubanderson,
davidgs,
jjasghar,
petecheslock,
robertgshaw2-redhat and
smarterclayton
as code owners
✅ Deploy Preview for elaborate-kangaroo-25e1ee ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Needs DCO sign-off |
jjk-g
changed the title
Author
|
DCO updated |
Member
|
Hey @jjk-g if you give this a rebase and fix the conflicts this should end up getting a clean CI run and we can get this reviewed/merged. |
jjk-g
force-pushed
the
main
branch
2 times, most recently
from
c3e9c69 to
424d67b
Compare
Signed-off-by: jjk-g <jkramberger@google.com>
Signed-off-by: jjk-g <jkramberger@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
At build time this appends a "Results Dashboard" section to the optimized-baseline guide with a blurb and iframe that embeds the corresponding Prism dashboard.
Why is this change needed?
Adds Prism links to the documentation.
How was this tested?
npm test)npm run build)npm start)Checklist
git commit -s) per DCOnpm test)npm run build)Related Issues