Verify that flags are correctly set when overflowing UAV resources#992
Verify that flags are correctly set when overflowing UAV resources#992joaosaffran wants to merge 4 commits intollvm:mainfrom
Conversation
joaosaffran
added
the
test-all
|
|
||
| # Unimplemented https://github.com/llvm/offload-test-suite/issues/305 | ||
| # XFAIL: Metal | ||
| # XFAIL: DXC && Vulkan && KosmicKrisp |
There was a problem hiding this comment.
Do we have an issue for this XFAIL?
There was a problem hiding this comment.
Is KosmicKrisp even a valid feature flag?
There was a problem hiding this comment.
Sorry, copy and paste forgot to update, this test was copied from unbounded-array.test. I've removed it, will create a new issue if such bugs persist in here as well
llvm-beanz
left a comment
llvm-beanz
left a comment
There was a problem hiding this comment.
Can you add a comment somewhere explaining where the overflow occurs? I don't see anything here that I'd expect is an overflow.
|
@llvm-beanz, edited the PR description comment. This test make sure the UAV count saturates at UNIT32_MAX when we are counting those to set Max64UAVs. We previously made some changes that lead us to figure this case wasn't being checked and we could overflow in there and incorrectly unset the flag. |
Remove XFAIL condition for DXC, Vulkan, and KosmicKrisp.
3 participants
This patch adds a new test to make sure we pass validation when UAV resources are overflowing. Such overflow would case Max64UAVs to not be set and the code wouldn't pass DXV validation