Update dependency @graphql-eslint/eslint-plugin to v4#217
Open
renovate[bot] wants to merge 5 commits intomainfrom
Open
Update dependency @graphql-eslint/eslint-plugin to v4#217renovate[bot] wants to merge 5 commits intomainfrom
renovate[bot] wants to merge 5 commits intomainfrom
Conversation
literat
force-pushed
the
dependencies/graphql-eslint-eslint-plugin-4.x
branch
from
2f5e825 to
3a9c02b
Compare
renovate
Bot
force-pushed
the
dependencies/graphql-eslint-eslint-plugin-4.x
branch
from
3a9c02b to
e625364
Compare
renovate
Bot
changed the title
renovate
Bot
force-pushed
the
dependencies/graphql-eslint-eslint-plugin-4.x
branch
3 times, most recently
from
1bfe622 to
25a7f1d
Compare
renovate
Bot
force-pushed
the
dependencies/graphql-eslint-eslint-plugin-4.x
branch
from
25a7f1d to
4dcc69c
Compare
literat
force-pushed
the
dependencies/graphql-eslint-eslint-plugin-4.x
branch
from
4dcc69c to
8f3f9bd
Compare
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
literat
force-pushed
the
bc/migrate-eslint-config-graphql
branch
from
59fa327 to
1074e5b
Compare
…rmat BREAKING CHANGES: * ESLint v9 is now required * package type is change to module * config format is changed to flat
literat
force-pushed
the
dependencies/graphql-eslint-eslint-plugin-4.x
branch
from
e9952e3 to
798bbe1
Compare
literat
approved these changes
Mar 29, 2026
There was a problem hiding this comment.
Pull request overview
Updates @graphql-eslint/eslint-plugin to v4 and migrates @alma-oss/eslint-config-graphql to ESLint 9 flat-config + ESM packaging.
Changes:
- Bump
@graphql-eslint/eslint-pluginto^4.0.0(and related GraphQL tooling deps via lockfile refresh). - Convert
@alma-oss/eslint-config-graphqlto an ESM, flat-config export and update peer dependency to ESLint^9. - Add unit tests and GraphQL schema fixtures to validate
.graphqllinting.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Lockfile refresh for @graphql-eslint/eslint-plugin@4 and transitive dependency graph updates. |
packages/eslint-config-graphql/package.json |
Switch to ESM (type: module), add exports, add unit test script, update deps/peers for ESLint 9 + graphql-eslint v4. |
packages/eslint-config-graphql/index.js |
Rewrite config as ESLint flat-config array using graphql-eslint plugin integration. |
packages/eslint-config-graphql/__tests__/index.test.js |
Add node:test-based tests validating config structure and .graphql lint results. |
packages/eslint-config-graphql/__tests__/__fixtures__/schema-valid.graphql |
Add valid schema fixture for lint tests. |
packages/eslint-config-graphql/__tests__/__fixtures__/schema-invalid.graphql |
Add invalid schema fixture to trigger known-type-names. |
packages/eslint-config-graphql/README.md |
Update docs to flat-config usage and describe embedded GraphQL processing + rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| export default [ | ||
| { | ||
| name: '@alma-oss/eslint-config-graphql', | ||
| files: [...globs.configs, ...globs.javascripts, ...globs.typescripts], |
There was a problem hiding this comment.
The processor is only applied to globs.javascripts and globs.typescripts, but globs.javascripts does not include *.jsx. This means embedded GraphQL in JSX files (common with React) won’t be processed/linted. Consider expanding the files patterns here to include *.jsx (and any other JS variants you support) so the README claim about embedded GraphQL applies to React code too.
Suggested change
| files: [...globs.configs, ...globs.javascripts, ...globs.typescripts], | |
| files: [...globs.configs, ...globs.javascripts, ...globs.typescripts, '*.jsx'], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^3.19.1→^4.0.0Release Notes
dimaMachina/graphql-eslint (@graphql-eslint/eslint-plugin)
v4.4.0Compare Source
v4.3.0Compare Source
v4.2.1Compare Source
v4.2.0Compare Source
v4.1.1Compare Source
v4.1.0Compare Source
v4.0.1Compare Source
v4.0.0Compare Source
Configuration
📅 Schedule: Branch creation - "after 9am and before 5pm on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.