Conversation
- Replace package-lock.json with pnpm-lock.yaml - Add packageManager field to package.json - Update CI workflows to use pnpm/action-setup and pnpm commands - Add dependabot cooldown of 3 days and github-actions ecosystem - Set npm.packageManager to pnpm in VS Code settings
- set-version action: use GITHUB_OUTPUT instead of GITHUB_ENV to prevent env injection via crafted branch names - dependabot-auto-merge: replace pull_request_target with pull_request and drop unnecessary checkout step - release: move permissions from workflow level to per-job scope; lock workflow-level permissions to empty
anisaoshafi
reviewed
May 6, 2026
anisaoshafi
reviewed
May 6, 2026
Comment on lines
+10
to
+12
| "js/ts.preferences.importModuleSpecifier": "shortest", | ||
| "js/ts.preferences.importModuleSpecifierEnding": "js", | ||
| "js/ts.preferences.preferTypeOnlyAutoImports": true, |
Contributor
There was a problem hiding this comment.
why were some of these settings changed to js/ts format? are these js/ts ones valid vs code settings?
Contributor
Author
There was a problem hiding this comment.
Yes, the previous values are deprecated and this is the correct new format. Maybe I should move these changes to a different PR
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Switching to
pnpmfor security: unlikenpm,pnpmdoes not runpostinstallscripts from dependencies by default, reducing the risk of supply chain attacks.The CI workflow changes enforce additional security hardening via zizmor (static analysis for GitHub Actions) and pinact (pins actions to full commit SHAs).
Changes
pnpm migration
package-lock.jsonwithpnpm-lock.yaml(generated viapnpm import)"packageManager": "pnpm@10.33.3"topackage.jsonvscode:prepublish,package, andpretestscripts to usepnpm runbuild.yml,release.yml) to usepnpm/action-setup,cache: pnpm, andpnpm install --frozen-lockfilepnpm security policy (
pnpm-workspace.yaml)postinstalletc.), withesbuildexplicitly allowlisted (required to download its platform binary)trustPolicy: no-downgradeto prevent package version rollbacksblockExoticSubdeps: trueto block non-standard subdependency specifiersminimumReleaseAge: 10080(7 days) to mirror the Dependabot cooldownCI hardening (zizmor + pinact)
set-versionaction: write to$GITHUB_OUTPUTinstead of$GITHUB_ENVto prevent env injection via crafted branch namesdependabot-auto-merge: replacepull_request_targetwithpull_requestand drop unnecessary checkout steprelease.yml: move permissions from workflow level to per-job scope; set workflow-levelpermissions: {}Dependabot
cooldown.default-days: 7(zizmor best practice) to npm and github-actions ecosystemsgithub-actionsecosystem tracking