Decouple sync and release actions#84
Conversation
9296029 to
09bb5a6
Compare
09bb5a6 to
784afee
Compare
784afee to
cd247e5
Compare
cd247e5 to
da5ff9f
Compare
da5ff9f to
398e6c9
Compare
398e6c9 to
2abe8b3
Compare
2abe8b3 to
51c9653
Compare
d12ab58 to
09b865f
Compare
09b865f to
2976974
Compare
2976974 to
bf2db95
Compare
4823bfa to
34212d7
Compare
34212d7 to
d37abda
Compare
alexrashed
left a comment
There was a problem hiding this comment.
Thanks for jumping on this! Great to see the sync being decoupled to support the future strategy. I only added a few small questions, mostly because I might not fully understand how the release cycles and the upgrade path of LocalStack is going to look like in the future... 😅
.github/workflows/ci_release.yml
Outdated
| - name: Guess next version | ||
| id: semver | ||
| uses: "WyriHaximus/github-action-next-semvers@v1" | ||
| with: | ||
| version: ${{ steps.previous.outputs.tag }} |
There was a problem hiding this comment.
question: How is this version determined and what do we expect the next few version numbers to look like?
There was a problem hiding this comment.
The previous action retrieves the latest Git tag. This action provides incremented the semantic versions, and we use the version with patch number bumped. This is because Moto-Ext is effectively feature-frozen, only a specific kind of bugfixes will be allowed.
There was a problem hiding this comment.
Thanks, that sounds good. I am just still a bit confused how this compares with the upstream versioning. In the other comment you mentioned that there might as well be selective pulls from upstream every now and then. How does the versioning scheme work with that?
Also, just to make sure we are talking about the same thing: When you say "micro" in the PR description, you mean "micro" as in PEP440, i.e. what you are calling "patch" here, right?
I guess my question is basically: What is the difference from the previous versioning to this kind of versioning and how is this going to look like considering the future of this project.
There was a problem hiding this comment.
In the other comment you mentioned that there might as well be selective pulls from upstream every now and then. How does the versioning scheme work with that?
There won't be any selective pulls. The rebase that happened this week was supposed to be the last, but because Simon and Daniel contributed to Moto upstream this week, we'll make an exception and do another rebase next week. That rebase will be the last rebase and Moto-Ext will effectively be frozen.
Since we've already announced the hard fork, I guess we can start using our own version scheme and not incorporate the minor verion bump that might come with the next week's rebase.
After this PR is merged, the version scheme will be strictly micro bumps.
When you say "micro" in the PR description, you mean "micro" as in PEP440, i.e. what you are calling "patch" here, right?
Yes, basically major.minor.micro. The term 'patch' (same meaning as 'micro') is what we use in our Semantic Versioning spec 😛
There was a problem hiding this comment.
Okay, thanks for the explanations, that makes sense! I guess we might cherry-pick certain commits in the future (for a while) from upstream, but I understand the next sync is going to be the last. I think my confusion came from the fact that we are keeping the sync workflow, but commit to never ever executing it again 😅
There was a problem hiding this comment.
question: Does it make sense to even keep this pipeline? You mentioned in the description that there is no plan to sync the fork with upstream anymore? If this is the case, I guess we could just remove this part / this workflow?
There was a problem hiding this comment.
We seem to need another bump (see #sig-moto) so I'd like to keep it for a while.
I'll make a separate PR in the future which cleans up this and other unused workflows from upstream.
There was a problem hiding this comment.
Okay, sounds good! As a nitpick on the side I would in this case also opt for renaming this workflow as well 😛
There was a problem hiding this comment.
nit: Might make sense to rename the workflows a bit. They don't have much to do with Continuous Integration anymore I guess 😅
alexrashed
left a comment
There was a problem hiding this comment.
Thanks for clarifying my questions in the comment threads! That helped me understand what the next steps are and how the project and its maintenance will look like in the future. 🚀
alexrashed
left a comment
There was a problem hiding this comment.
Thanks for jumping on the comments, but this change would now actually fail the pipeline regularly, which I don't think is the intention.
265ad84 to
7830b31
Compare
442feb2 to
f7da210
Compare
f7da210 to
7f0530b
Compare
c27ed0b to
960aa99
Compare
960aa99 to
4e623d8
Compare
290cac0 to
7830b31
Compare
alexrashed
left a comment
There was a problem hiding this comment.
Thanks for jumping on the comments! The pipeline is looking great now! 💯
Background
Moto-Ext current has an action that rebases the codebase with upstream repo and publishes the build to PyPI, introduced in #78.
Changes
Following the hard fork (see #83), Moto-Ext will not be rebased with the upstream repo. This PR therefore reworks this CI pipeline and splits it into two separate workflows:
Tests
Successful dry runs for:
Related
Closes: PNX-558