Merged
Conversation
7b11bec to
042098f
Compare
d2aaeef to
7127d95
Compare
dfangl
approved these changes
Mar 12, 2026
Member
dfangl
left a comment
There was a problem hiding this comment.
LGTM! Makes sense, and the additional tests are great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#35 adds support for Hatchling as a build backend for the automatic discovery of plugins and to populate the
plux.ini.However, in contrast to
setuptools, hatchling does not natively support fetching theentry-pointsfrom an external file. Insteadhatchlingprovides an explicit "metadata hook" to allow simply dynamically modifying the project metadata.This PR extends #35 by adding an explicit
PluxMetadataHookwhich takes care of populating the entrypoints of the project with theplux.inifile.Changes
plux.build.hatchlingwith a simplePluxMetadataHook.TODO