refactor: use new styling for conversations crate without mod.rs#72
Open
kaichaosun wants to merge 2 commits intomainfrom
Open
refactor: use new styling for conversations crate without mod.rs#72kaichaosun wants to merge 2 commits intomainfrom
kaichaosun wants to merge 2 commits intomainfrom
Conversation
jazzz
approved these changes
Mar 25, 2026
core/conversations/src/storage.rs
Outdated
| //! Chat-specific storage implementation. | ||
|
|
||
| mod migrations; | ||
| pub(crate) mod types; |
Collaborator
There was a problem hiding this comment.
Love that the visibility is scoped and not simply pub.
[Sand] One thing to watch out for is that this object is only accessible outside of the module via the submodule 'types' which bleeds internal abstractions outside of the module. If the type IdentityRecord is needed outside of the Storage module, a pub use statement would hide the internal details of where that is stored - making the module more self contained.
From what I can see IdentityRecord is only used within this module for now, so hard for me to see how it will be used. I'd check to see if pub is needed at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the follow up PR to clean the repo to use new module styling.
More context: #68