Skip to content

fix(server): remove connection stats feature#1063

Merged
lollipopkit merged 1 commit intomainfrom
fix/remove-connection-stats-1062
Mar 6, 2026
Merged

fix(server): remove connection stats feature#1063
lollipopkit merged 1 commit intomainfrom
fix/remove-connection-stats-1062

Conversation

@lollipopkit
Copy link
Owner

@lollipopkit lollipopkit commented Mar 6, 2026

Summary

  • remove the connection statistics page and its entry points from settings and the desktop top bar
  • stop recording and clearing connection statistics during server connect/delete flows
  • keep the legacy connection stats store initialized so existing local database files remain intact

Verification

  • flutter analyze lib test
  • flutter test

Fixes #1062

Summary by CodeRabbit

  • Refactor
    • Connection statistics feature has been removed from the application, including data tracking and the dedicated statistics viewing page.
    • Connection status is no longer an interactive element for viewing detailed statistics.
    • Connection statistics option has been removed from server settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 035f0be0-6e1b-4c91-8b5f-67be12631f2d

📥 Commits

Reviewing files that changed from the base of the PR and between ac46073 and f8a4860.

📒 Files selected for processing (8)
  • lib/data/provider/server/all.dart
  • lib/data/provider/server/single.dart
  • lib/data/res/store.dart
  • lib/view/page/server/connection_stats.dart
  • lib/view/page/server/tab/tab.dart
  • lib/view/page/server/tab/top_bar.dart
  • lib/view/page/setting/entries/server.dart
  • lib/view/page/setting/entry.dart
💤 Files with no reviewable changes (5)
  • lib/data/provider/server/all.dart
  • lib/view/page/server/tab/tab.dart
  • lib/view/page/setting/entry.dart
  • lib/view/page/server/connection_stats.dart
  • lib/view/page/setting/entries/server.dart

📝 Walkthrough

Walkthrough

This PR removes connection statistics tracking functionality throughout the application. Changes include deleting the ConnectionStatsPage UI component, removing connection stats recording during SSH connection attempts, eliminating cleanup calls during server deletion, and removing navigation links to the stats page. A comment is added to the connectionStats store getter to preserve the legacy database box for backward compatibility.

Possibly related PRs

  • PR #1027: Modifies server deletion hooks and connection stats UI/logic—this PR removes recording and cleanup calls for connection statistics, while the related PR adds compaction and clearing functionality to the same features.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing the connection stats feature from the server module.
Linked Issues check ✅ Passed The PR addresses issue #1062 by removing connection stats recording/clearing operations and the stats UI, which are likely contributing to the reported startup delays and SSH reconnection failures.
Out of Scope Changes check ✅ Passed All changes are directly related to removing the connection stats feature as described in the objectives; no unrelated modifications were introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/remove-connection-stats-1062

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@lollipopkit lollipopkit merged commit 04b47a3 into main Mar 6, 2026
1 check passed
@lollipopkit lollipopkit deleted the fix/remove-connection-stats-1062 branch March 6, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

能不能赶紧出新版本?真的要崩溃了

1 participant