[I2C, hal, SW] Restructured and refactored the functions#535
Open
KinzaQamar wants to merge 4 commits into
Open
[I2C, hal, SW] Restructured and refactored the functions#535KinzaQamar wants to merge 4 commits into
KinzaQamar wants to merge 4 commits into
Conversation
KinzaQamar
force-pushed
the
i2c_sw_modif
branch
8 times, most recently
from
c431f00 to
a0269e1
Compare
engdoreis
reviewed
May 8, 2026
KinzaQamar
force-pushed
the
i2c_sw_modif
branch
8 times, most recently
from
49e9862 to
ab7f1dc
Compare
KinzaQamar
force-pushed
the
i2c_sw_modif
branch
3 times, most recently
from
79c9fa4 to
bb82b9a
Compare
Taking the transfer checking part out from the i2c_read_byte() and i2c_write_byte() functions. It is needed when you want to controller wants to read / write multiple bytes. Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
This is suggested in programmer's guide. As a precautionary step, reset the FMT fifo before sending any transfer Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
Contributor
Author
|
Tested 
|
engdoreis
reviewed
May 13, 2026
| if (i == (num_wr_bytes - 1u)) { | ||
| fdata_reg.stop = 1u; | ||
| } | ||
| VOLATILE_WRITE(i2c->fdata, fdata_reg); |
Collaborator
There was a problem hiding this comment.
you should check that the fifo is not full on every iteration, otherwise it would overflow when num_wr_bytes is large.
| bool check_wr_xfer_status(i2c_t i2c) | ||
| { | ||
| // Wait for transaction to complete and report simple succeed / fail | ||
| for (uint32_t ii = 0; ii < 10000000ul /*arbitrary number*/; ii++) { |
Collaborator
There was a problem hiding this comment.
why we need to check the timeout? The arbitrary number of iterations is brittle. Since this code is only used for testing, and tests already have timeout mechanims. I would replace the for loop for a while (true)
Same for the function below.
| VOLATILE_WRITE(i2c->fdata, fdata_reg); | ||
| } | ||
|
|
||
| bool check_wr_xfer_status(i2c_t i2c) |
Collaborator
There was a problem hiding this comment.
The check name sugests that there's no loop.
Suggested change
| bool check_wr_xfer_status(i2c_t i2c) | |
| bool wait_for_completion(i2c_t i2c) |
Same for the function below.
Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking the transfer checking part out from the i2c_read_byte() and i2c_write_byte() functions. It is needed when you want to controller wants to read / write multiple bytes.
Merge #545 first as a dependency on this PR