chore(practices): capture CI-hygiene practice + incorporate two lessons#4
Open
luiseiman wants to merge 1 commit into
Open
chore(practices): capture CI-hygiene practice + incorporate two lessons#4luiseiman wants to merge 1 commit into
luiseiman wants to merge 1 commit into
Conversation
Process the practices inbox (1 item to active). Lessons from PR #3: - _common.md Git: verify base-branch CI is green before opening a PR — a preexisting red required check blocks every PR and masks degraded workflows. - CLAUDE.md Audit System: flag that score.sh (bash CI gate) and audit_all.py (Python re-auditor) reimplement the checklist independently — any checklist change must update both engines + audit.yml + docs. practices/active/2026-06-03-verify-ci-state-before-pr.md documents both. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Procesa el inbox de prácticas (1 item → active) tras el PR #3.
Lecciones incorporadas
.claude/rules/_common.md§ Git: verificar que el CI esté verde en la base branch antes de abrir un PR. Un check rojo preexistente bloquea todo PR y enmascara workflows degradados (el CI de main estuvo rojo en 3 commits desde el release v4.0.0 hasta que feat(v4): audit two-dimension model — Native Health + dotforge Adoption #3 lo arregló).CLAUDE.md§ Audit System:score.sh(bash, CI gate) yaudit_all.py(Python, re-auditor) reimplementan el checklist por separado — todo cambio al checklist debe tocar ambos motores +audit.yml+ docs.Archivos
.claude/rules/_common.md— regla pre-PRCLAUDE.md— nota de dual-enginepractices/active/2026-06-03-verify-ci-state-before-pr.md— práctica con reglas derivadasNota de proceso
El
git pushde este mismo PR fue bloqueado por el behavior v3verify-before-done(soft_block) por no haber corrido verificación en la tanda. Se resolvió por el camino correcto — corriendo las suites (14 tests verdes) — no por override. El behavior funcionó como diseñado.🤖 Generated with Claude Code