"feat: allow cookie-based auth to bypass recaptcha" #32
Conversation
substack/api.py
Outdated
| if not custom_domain: | ||
| publication_url = f"https://{publication['subdomain']}.substack.com" | ||
| else: | ||
| if publication['custom_domain_optional']: |
There was a problem hiding this comment.
this should be a get to avoid KeyError for the custom_domain_optional key
substack/cookie_session.py
Outdated
| super().__init__() | ||
| with open(cookie_file, "r", encoding="utf-8") as f: | ||
| raw = json.load(f) | ||
| self.cookies = cookiejar_from_dict({c["name"]: c["value"] for c in raw}) |
There was a problem hiding this comment.
does this fully replace the cookies with the content of the json file? if so then it is should update the cookies dict instead of replacing it in order to not break the behavior of
self._session.cookies.update(cookies)
There was a problem hiding this comment.
That’s true, so I removed CookieSession.py (it was no longer needed) and updated the cookie-session instance instead.
|
Hi, i merged the part regarding custom_domain_optional, please let me know if it works fine, still don't understand that field. the cookie part i don't think is necessary. I also just added a cookie string field which makes them easier to pass as an env var @SajjadKiani |
2 participants
i add the "cookie_session" for bypass the captcha and fix some issue with substack changes