GLPathItem: Remove tool offset from calculation#297
Draft
gb-g wants to merge 1 commit into
Draft
Conversation
Paths with tool offset are now displayed the same way as in AXIS.
|
This pull request is in draft status intentionally and not by accident, right? |
gb-g
force-pushed
the
paths-with-tool-offset
branch
6 times, most recently
from
2ad595f to
734af97
Compare
Author
|
Yes. Feedback is welcome, though! |
Member
|
Interesting, if it works, this looks good. However, it indicates that the reported machine position is not absolute. Since this is the preview module only, I think it is okay, just worth mentioning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paths that have a tool offset are displayed wrong.
This PR displays them the same way as in AXIS.
Tested on LInux, on a lathe, with tool offset: Path display as in AXIS, and the tool offset is still used by the lathe machine itself.