Fix Homebrew iconv builds and Lua 5.5 dynamic builds#1635
Merged
ychin merged 2 commits intomacvim-dev:masterfrom Apr 4, 2026
Merged
Fix Homebrew iconv builds and Lua 5.5 dynamic builds#1635ychin merged 2 commits intomacvim-dev:masterfrom
ychin merged 2 commits intomacvim-dev:masterfrom
Conversation
CI builds switched to using Homebrew iconv instead of native one in macvim-dev#1626, but for non-publish builds this assumed libiconv was installed by Homebrew, which wasn't always the case. This led to build failures if Homebrew didn't have it installed. Fix it so that we only use Homebrew libiconv in publish builds and use Apple iconv otherwise. This also helps test that both versions work correctly in CI.
Cherry-picked from vim/vim#19909
ychin
added
Infrastructure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.