Restore massive RAMBO reshuffling in CUDACPP SA RAMBO path#1091
Draft
Copilot wants to merge 3 commits into
Draft
Restore massive RAMBO reshuffling in CUDACPP SA RAMBO path#1091Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Copilot created this pull request from a session on behalf of
oliviermattelaer
June 11, 2026 14:52
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rambo.hin the CUDACPP SA plugin templates was missing the massive-particle reshuffling step, producing incorrect phase-space kinematics/weights for processes with non-zero final-state masses. This change restores the MG5_aMC@NLO-aligned massive branch and wires final-state masses through the sampling stack.RAMBO algorithm: restore massive branch (
rambo.h)xsolve) for non-zero final-state masses.wtm) and warning counters for massive-path overflow/underflow.ramboGetMomentaFinal(...)signature withconst fptype* massesFinal(defaulting to null for massless behavior).Sampling kernel interface: carry mass data end-to-end
SamplingKernelBase,RamboSamplingKernelHost, andRamboSamplingKernelDeviceto accept/store final-state masses.massesFinal.Process integration: source final-state masses from process model
CPPProcess::getMasses()accessor in template process class.check_sa.cc, extracted final-state slice viaprocess.getMasses().data() + CPPProcess::npariand passed it into RAMBO sampling kernel construction.