Skip to content

chore: upgrade spl example#68

Merged
GabrielePicco merged 1 commit intomainfrom
feat/updade-example
Mar 22, 2026
Merged

chore: upgrade spl example#68
GabrielePicco merged 1 commit intomainfrom
feat/updade-example

Conversation

@GabrielePicco
Copy link
Copy Markdown
Contributor

@GabrielePicco GabrielePicco commented Mar 22, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Added validation to prevent encrypted private transfer operations when validator is not initialized.
    • Improved transaction logging to display source and destination addresses with their associated token accounts.
    • Optimized account data fetching during delegation operations.
  • Chores

    • Updated SDK dependency to version 0.10.1.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
er-rolldice Ready Ready Preview, Comment Mar 22, 2026 6:03pm
magicblock-engine-examples Ready Ready Preview, Comment Mar 22, 2026 6:03pm
spl-tokens Ready Ready Preview, Comment Mar 22, 2026 6:03pm

Request Review

@GabrielePicco GabrielePicco merged commit b562eb0 into main Mar 22, 2026
1 of 7 checks passed
@GabrielePicco GabrielePicco deleted the feat/updade-example branch March 22, 2026 18:01
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 22, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 69549d70-07d6-42cf-91c4-e51f73bcf4f5

📥 Commits

Reviewing files that changed from the base of the PR and between 98d543d and 2f1730c.

⛔ Files ignored due to path filters (1)
  • spl-tokens/app/app/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • spl-tokens/app/app/package.json
  • spl-tokens/app/app/src/App.tsx

Walkthrough

This PR updates the @magicblock-labs/ephemeral-rollups-sdk dependency to a pinned version and modifies the transfer logic in App.tsx to add validator validation, compute destination token addresses, comment out account-info fetches, and enhance transaction logging.

Changes

Cohort / File(s) Summary
Dependency Version Pin
spl-tokens/app/app/package.json
Updated @magicblock-labs/ephemeral-rollups-sdk from ^0.10.0 to exact version 0.10.1, switching from flexible version resolution to locked version.
Transfer Logic Enhancement
spl-tokens/app/app/src/App.tsx
Added validator loading guard in performTransfer for encrypted private transfers; computed destination user's associated token address; commented out ephemeral account-info fetches in delegate/undelegate flows; expanded post-transaction logging to include source/destination keys and ATAs.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Feat/new spl flow #67: Modifies the same performTransfer function in App.tsx and updates the @magicblock-labs/ephemeral-rollups-sdk dependency in tandem, indicating coordinated changes.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/updade-example

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant