fix: handle missing corepack in setup.sh with npm fallback#9202
Open
valkrypton wants to merge 1 commit into
Open
fix: handle missing corepack in setup.sh with npm fallback#9202valkrypton wants to merge 1 commit into
valkrypton wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe setup.sh script now checks for the presence of corepack before enabling pnpm; if corepack is missing it prints Node.js/corepack installation guidance and exits. If corepack is present it runs ChangesSetup Script Improvements
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@setup.sh`:
- Around line 84-89: The npm-based fallback in the elif branch (the lines that
call `npm install -g corepack`, `npm install -g pnpm`, and the fallback block)
violates the package-manager policy; remove the npm-based installation logic and
instead attempt only `corepack enable pnpm` when corepack is present, and if
corepack is not available or enabling fails, print a clear remediation error
(e.g., instructing the user to install Corepack or pnpm manually) and exit
non‑zero (set success=false or call exit 1). Update the branch that currently
runs when `command -v npm` would match so it only reports the missing
Corepack/PNPM path and fails, referencing the existing conditional block that
echoes "${YELLOW}corepack not found — installing pnpm via npm...${NC}" to
replace that behavior with the policy-compliant failure message.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Replaces npm fallback with an explicit error directing users to install Node.js 16.9+, keeping setup.sh pnpm/corepack-only per repo policy. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
valkrypton
force-pushed
the
fix/setup-corepack-fallback
branch
from
daf2c19 to
dce8679
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Falls back to npm install -g corepack, then npm install -g pnpm if corepack is unavailable. Adds guard before pnpm install to avoid silent exit 127.
Description
Type of Change
Summary by CodeRabbit