Minor refactoring of route line view #5631
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wed by traffic calculations and gradient updating.
cafesilencio
force-pushed
the
sb-alt-route-selection
branch
from
7e0f373 to
4ee70b4
Compare
Author
|
@LukasPaczos please take a look when you have some time. |
Codecov Report
@@ Coverage Diff @@
## main #5631 +/- ##
=========================================
Coverage 66.66% 66.67%
+ Complexity 3692 3691 -1
=========================================
Files 569 569
Lines 23287 23302 +15
Branches 2656 2659 +3
=========================================
+ Hits 15525 15537 +12
Misses 6802 6802
- Partials 960 963 +3
|
|
Wondering if by delaying the layer property updates we risk that a wrong vanishing offset will be applied to the new geometry, etc. That's why I'd prefer us to make the updates for sources and layers based on these sources as close to each other as possible. What do you think? Refs #5688. |
Author
|
Given the refactoring that is taking place to address: #5687, this PR has become irrelevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently a customer asked for additional optimization around the process of selecting alternative routes. The rendering when redrawing long routes seemed longer than in the SDK's previous release. Although most of the rendering time is on the map side, this PR rearranges some of the calls to emphasize setting the line sources to get that process happening as early as possible. At the same time the calls to recalculate traffic gradients are executed on a background thread in parallel. This is a minor optimization. The bulk of the optimization is being explored on the map side.
Screenshots or Gifs