Conversation
ccddef8 to
a759374
Compare
Codecov Report
@@ Coverage Diff @@
## main #6326 +/- ##
=========================================
Coverage 68.88% 68.88%
Complexity 4504 4504
=========================================
Files 681 681
Lines 27002 27002
Branches 3162 3162
=========================================
Hits 18601 18601
Misses 7182 7182
Partials 1219 1219 |
a759374 to
54d7daf
Compare
Zayankovsky
approved these changes
Sep 15, 2022
libnavui-androidauto/src/main/java/com/mapbox/androidauto/car/navigation/CarArrivalTrigger.kt
Outdated
Show resolved
Hide resolved
fffadb0 to
c5880e0
Compare
c5880e0 to
a0abb34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addressing #6141
After removing
MapboxNavigationfromCarActiveGuidanceCarContextand fixing upActiveGuidanceScreen, it was clear that we no longer needCarActiveGuidanceCarContextso this is deleting it 🎉This also moves the
PlacesListOnMapLayerUtilout of the constructor. We may want to add marker customizations but this is not how we can do it. Anything we want to do there can be handled first by the newCarActiveGuidanceMarkers.Adding
CarArrivalTriggeras a definition for what to do when the arrival happen. It was in theActiveGuidanceScreen, but moving it to a separate class will make it easy for us to integrate into the installer #6211I'm opening this now and would be happy to merge it. Otherwise I'll add tests to the new classes because that logic does not have any coverage.