Reinitialize route line layers every time initialize is called.#6793
Merged
LukasPaczos merged 2 commits intomainfrom Feb 3, 2023
Merged
Reinitialize route line layers every time initialize is called.#6793LukasPaczos merged 2 commits intomainfrom
LukasPaczos merged 2 commits intomainfrom
Conversation
de2f25e to
3ba04b4
Compare
cb71365 to
33a1383
Compare
Codecov Report
@@ Coverage Diff @@
## main #6793 +/- ##
============================================
+ Coverage 72.93% 72.98% +0.04%
- Complexity 5662 5667 +5
============================================
Files 786 786
Lines 30456 30505 +49
Branches 3607 3607
============================================
+ Hits 22214 22263 +49
Misses 6810 6810
Partials 1432 1432
|
101fb7c to
e9e1363
Compare
LukasPaczos
reviewed
Jan 10, 2023
libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/MapboxRouteLineView.kt
Outdated
Show resolved
Hide resolved
libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/MapboxRouteLineView.kt
Outdated
Show resolved
Hide resolved
libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/MapboxRouteLineView.kt
Show resolved
Hide resolved
9d45d3f to
14a7396
Compare
ChangelogFeatures
Bug fixes and improvementsFixed "global reference table overflow" in case an application accumulates and keeps links to
Known issues
|
LukasPaczos
reviewed
Jan 26, 2023
libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/MapboxRouteLineView.kt
Outdated
Show resolved
Hide resolved
libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/MapboxRouteLineView.kt
Outdated
Show resolved
Hide resolved
libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/MapboxRouteLineView.kt
Outdated
Show resolved
Hide resolved
…ptions even if it means removing the existing layers.
14a7396 to
9905db4
Compare
|
In the interest of pushing this work forward I updated the PR with a minimal set of changes needed to resolve the issue reported upstream. If we want to consider expanding the API surface, let's discuss this separately. |
LukasPaczos
approved these changes
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the
MapboxRouteLineView::initializeLayersis called any existing route line related layers will be removed and the layers will be re-added with the current options. Previously the layers would only be initialized if they previously didn't exist. CallinginitializeLayerswill always result in the same map state with regard to the layers related to the route line.Screenshots or Gifs