Skip to content

Initial commit for Feedback Agent#7945

Open
reline wants to merge 3 commits intolts/v2from
nr/NAVAND-6309-feedback-agent
Open

Initial commit for Feedback Agent#7945
reline wants to merge 3 commits intolts/v2from
nr/NAVAND-6309-feedback-agent

Conversation

@reline
Copy link
Copy Markdown

@reline reline commented Mar 26, 2026

No description provided.

@reline reline requested a review from a team as a code owner March 26, 2026 23:40
@reline reline added skip changelog Should not be added into version changelog. v2.x Related to version 2.x. labels Mar 26, 2026
@reline reline force-pushed the nr/NAVAND-6309-feedback-agent branch from eb533b0 to 2924c97 Compare March 27, 2026 00:11
@reline reline force-pushed the nr/NAVAND-6309-feedback-agent branch from 2924c97 to 705c997 Compare March 27, 2026 00:30
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 13.47099% with 880 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.31%. Comparing base (ddc6b6a) to head (705c997).

Files with missing lines Patch % Lines
...voicefeedback/internal/audio/AudioInfoRetriever.kt 0.00% 209 Missing ⚠️
...navigation/voicefeedback/internal/WebSocketDTOs.kt 0.00% 168 Missing ⚠️
...igation/voicefeedback/internal/MapboxASRService.kt 0.00% 159 Missing ⚠️
...internal/audio/microphone/AudioRecordMicrophone.kt 0.00% 121 Missing ⚠️
...x/navigation/voicefeedback/FeedbackAgentSession.kt 0.00% 65 Missing ⚠️
.../navigation/voicefeedback/FeedbackAgentEndpoint.kt 0.00% 29 Missing ⚠️
...efeedback/internal/FeedbackAgentContextProvider.kt 0.00% 28 Missing ⚠️
...x/navigation/voicefeedback/FeedbackAgentOptions.kt 0.00% 26 Missing ⚠️
.../voicefeedback/internal/FeedbackAgentContextDTO.kt 0.00% 26 Missing ⚠️
...com/mapbox/navigation/voicefeedback/FeedbackExt.kt 0.00% 12 Missing ⚠️
... and 5 more

Impacted file tree graph

@@             Coverage Diff              @@
##             lts/v2    #7945      +/-   ##
============================================
- Coverage     74.08%   72.31%   -1.77%     
- Complexity     6260     6271      +11     
============================================
  Files           856      872      +16     
  Lines         33813    34830    +1017     
  Branches       4027     4147     +120     
============================================
+ Hits          25051    25188     +137     
- Misses         7205     8082     +877     
- Partials       1557     1560       +3     
Files with missing lines Coverage Δ
...apbox/navigation/voicefeedback/internal/AsrData.kt 100.00% <100.00%> (ø)
.../com/mapbox/navigation/voicefeedback/Microphone.kt 80.00% <80.00%> (ø)
...vigation/voicefeedback/internal/AsrSessionState.kt 55.55% <55.55%> (ø)
...x/navigation/voicefeedback/internal/FeedbackDTO.kt 0.00% <0.00%> (ø)
...va/com/mapbox/navigation/voicefeedback/ASRState.kt 52.17% <52.17%> (ø)
...com/mapbox/navigation/voicefeedback/FeedbackExt.kt 0.00% <0.00%> (ø)
...internal/MapboxAutomaticSpeechRecognitionEngine.kt 89.47% <89.47%> (ø)
...x/navigation/voicefeedback/FeedbackAgentOptions.kt 0.00% <0.00%> (ø)
.../voicefeedback/internal/FeedbackAgentContextDTO.kt 0.00% <0.00%> (ø)
...efeedback/internal/FeedbackAgentContextProvider.kt 0.00% <0.00%> (ø)
... and 6 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@vadzim-vys vadzim-vys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the public API perspective. I didn't dive deep into implementation details nor tested that by running.
The only blocking comment for me is about updating common version without updating rest of the native dependencies.

mapboxMapSdk : '10.19.0',
mapboxSdkServices : '7.1.0',
mapboxNavigator : "${mapboxNavigatorVersion}",
mapboxCommonNative : '23.11.4',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually update all native dependencies together, given the fact that maps and nav native is being tested with specific versions of common and may rely on internal api

import org.junit.rules.TestWatcher
import org.junit.runner.Description

class MapboxNavigationRule : TestWatcher() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that possible to reuse existing infrastructure instead of keeping copies in the module?

Comment on lines +59 to +60
fun testFeedbackReport() = runBlocking(Dispatchers.Main.immediate) {
withTimeout(30.seconds) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that possible to use sdkTest from the tests infrastructure?

Copy link
Copy Markdown
Contributor

@vadzim-vys vadzim-vys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Should not be added into version changelog. v2.x Related to version 2.x.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants