Use undefined instead of null as the default value#112
Merged
mourner merged 2 commits intomapbox:masterfrom Nov 12, 2019
Merged
Use undefined instead of null as the default value#112mourner merged 2 commits intomapbox:masterfrom
mourner merged 2 commits intomapbox:masterfrom
Conversation
This fixes the type issues in mapbox#107. Also it makes more sense. I'm unsure about the `return undefined`.
Contributor
Author
|
PS: I'm not sure about the |
mourner
requested changes
Nov 6, 2019
Member
mourner
left a comment
mourner
left a comment
There was a problem hiding this comment.
Can you investigate the failing tests as a result of this change?
Contributor
Author
|
Tests fixed. I guess maybe this should go in a major release because it technically breaks the API, but on the other hand it doesn't look like this behaviour was actually documented anywhere. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the typescript type errors in #107 and just makes more sense if you ask me.