Skip to content

fix some task review status not found and locking bugs #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CollinBeczak merged 2 commits into from
Mar 18, 2026
+10 −4
Merged

fix some task review status not found and locking bugs #1207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7df15ba
fix some task review status not found and locking bugs
CollinBeczak Feb 2, 2026
893d333
Fix formatting issue in Task.scala by removing extra space in STATUS_…
CollinBeczak Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions app/org/maproulette/framework/model/Task.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,9 +324,15 @@
if (allowChange)
toSet == STATUS_FIXED || toSet == STATUS_FALSE_POSITIVE || toSet == STATUS_TOO_HARD
else false
case STATUS_ANSWERED => false
case STATUS_VALIDATED => false
case STATUS_DISABLED => toSet == STATUS_CREATED
case STATUS_ANSWERED =>
if (allowChange)
toSet == STATUS_FIXED || toSet == STATUS_FALSE_POSITIVE || toSet == STATUS_ALREADY_FIXED || toSet == STATUS_TOO_HARD
else false

Check warning on line 330 in app/org/maproulette/framework/model/Task.scala

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal. 


See more on https://sonarcloud.io/project/issues?id=maproulette_maproulette2&issues=AZ0BgtRvPm9DgMgZ6Qyu&open=AZ0BgtRvPm9DgMgZ6Qyu&pullRequest=1207
case STATUS_VALIDATED =>
if (allowChange)
toSet == STATUS_FIXED || toSet == STATUS_FALSE_POSITIVE || toSet == STATUS_ALREADY_FIXED || toSet == STATUS_TOO_HARD
else false

Check warning on line 334 in app/org/maproulette/framework/model/Task.scala

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal. 


See more on https://sonarcloud.io/project/issues?id=maproulette_maproulette2&issues=AZ0BgtRvPm9DgMgZ6Qyv&open=AZ0BgtRvPm9DgMgZ6Qyv&pullRequest=1207

Check warning on line 334 in app/org/maproulette/framework/model/Task.scala

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

This branch's code block is the same as the block for the branch on line 328. 


See more on https://sonarcloud.io/project/issues?id=maproulette_maproulette2&issues=AZ0BgtRvPm9DgMgZ6Qyt&open=AZ0BgtRvPm9DgMgZ6Qyt&pullRequest=1207
case STATUS_DISABLED => toSet == STATUS_CREATED
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/org/maproulette/framework/service/TaskReviewService.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,7 @@ class TaskReviewService @Inject() (
excludeOtherReviewers
)

addClaimedByFilter(query, user.id)
addLockedFilter(addClaimedByFilter(query, user.id))
}

private def addClaimedByFilter(query: Query, userId: Long): Query = {
Expand Down
Loading