Add stable ranges and structured diagnostics#92
Conversation
|
History has been cleaned up and force-pushed as signed commits while preserving the original commit timestamps. Latest validation on the rewritten branch head
Keeping the PR in draft because the branch is not yet confidently within the ±1% benchmark gate overall: eval is better than |
|
Added commit Validation on the pushed commit:
Results:
Selected parse suite results:
This clears the previous parse gate: the branch is now confidently within, and in aggregate better than, the |
|
Thanks for the PR and sorry to let you wait. Isolating changes would help in merging quicker 😉 |
|
No problem, thanks for the feedback :) I really didn't want performance regressions in comparison against main, which is why I added the |
marcbachmann
left a comment
There was a problem hiding this comment.
Just some questions while I'm already iterating on a few things.
No need for you to go into the code at the moment.
8114722 to
613353e
Compare
…meter to define code, message, cause, node and range
|
I hope you're happy with that simplified solution. Thanks for the PR. |
|
🎉 This PR is included in version 7.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
start/endranges to AST nodes, parse errors, and diagnosticsmainby preservingcauseas the third argument and moving structured metadata to the optional fourth argumentCloses #90
Testing
npm test(1031/1031)Benchmark Rerun
Same-machine rerun on
main(5763f7c) vs this branch head (165246e):Overall
1.0225x, CI+0.37%to+3.84%)1.0247x, CI+0.96%to+4.20%)Parse suite highlights
accessors: +2.53% (CI+1.18%to+3.68%)arithmetic: +1.94% (CI+0.29%to+3.40%)logic: +2.70% (CI+1.80%to+3.70%)collections: +1.51% (CI-0.20%to+3.20%)functions: +2.00% (CI-0.22%to+4.41%)literals: +3.40% (CI-0.58%to+8.61%)macros: +1.56% (CI-2.04%to+5.20%)Notable cases
accessors / parse / Int access: +6.75% (CI+3.29%to+10.11%)logic / parse / Logical Expression: +6.35% (CI+5.73%to+6.97%)collections / parse / Empty Map Creation: +6.05% (CI+3.13%to+8.37%)literals / parse / String concat with variables: -5.47% (CI-9.83%to-1.64%)collections / parse / List of Maps Access: -2.23% (CI-3.91%to-0.77%)Readiness Gate
This PR is now ready for review: the benchmark results are confidently within, and in aggregate better than, the
±1%threshold againstmain.