Fix missing noopener on external chat markdown links#21
Draft
sabraman wants to merge 1 commit intomaria-rcks:mainfrom
Draft
Fix missing noopener on external chat markdown links#21sabraman wants to merge 1 commit intomaria-rcks:mainfrom
sabraman wants to merge 1 commit intomaria-rcks:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
External links rendered by
ChatMarkdownopened in a new tab withrel="noreferrer"but withoutnoopener.This path is used for links that are not resolved to local workspace files, so the web UI was missing the standard hardening that prevents the opened page from getting a handle back to the opener.
What changed
noopeneralongsidenoreferrerfor external markdown links rendered inChatMarkdownVerification
bun x vitest run apps/web/src/components/ChatMarkdown.test.tsxbun fmt --checkbun lintbun typecheck