tgon/tgoff commands to turn on/off messages, jdbc integration to store players, refactoring #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 865ec56)
Owner
|
Thanks for your PR. I have never really looked into this Hibernate thingy, but is it really needed for a project this size? It seems like it introduces a few new libraries too, like the javassist lib, xml libs etc. I don't understand why it needs Javassist, Hibernate should only alter existing fields but isn't expected to compile new classes at runtime, right? Currently, the jar with all dependencies has a size of ~17 MiB. That's far too big for a simple MC plugin imho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to make tgon/tgoff commands, also to integrate with Hibernate and a database.
All changes have been made for my own needs, but I hope some of them could be useful :-)