Fixes 1992#2000
Open
affeldt-aist wants to merge 3 commits into
Open
Conversation
Co-authored-by: Yosuke Ito <glacier345@gmail.com>
t6s
reviewed
Jun 15, 2026
t6s
left a comment
t6s
left a comment
Member
There was a problem hiding this comment.
I am confused at a comment on closure_setC, but other parts look good.
| Proof. by rewrite -interiorC interiorEbigcup. Qed. | ||
| #[deprecated(since="mathcomp-analysis 1.7.0", note="use `interiorC` and `interiorEbigcup` instead")] | ||
| Notation closureC := closureC_deprecated (only parsing). | ||
| (*#[deprecated(since="mathcomp-analysis 1.17.0", note="renamed to `closureC`")] |
Member
There was a problem hiding this comment.
this should be uncommented and moved to line 898
Member
Author
There was a problem hiding this comment.
Yes, it should be uncommented, but it should stay here because inside a section, a notation becomes local by default.
Member
Author
There was a problem hiding this comment.
Thanks for catching it!
t6s
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fixes #1992
Checklist
CHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers