fsync Implementation#23
Draft
vidyasilai wants to merge 2 commits into
Draft
Conversation
tonyastolfi
reviewed
May 26, 2026
tonyastolfi
reviewed
May 26, 2026
|
|
||
| //==#==========+==+=+=++=+++++++++++-+-+--+----- --- -- - - - - | ||
| // | ||
| Status KVStore::sync(Optional<i64> upper_bound) noexcept |
Collaborator
There was a problem hiding this comment.
Optional<i64> -> Optional<EditOffset>?
tonyastolfi
reviewed
May 26, 2026
| EditOffsetDelta{(i64)packed_key_value_slot_size(key, value)}; | ||
| } | ||
|
|
||
| return OkStatus(); |
tonyastolfi
reviewed
May 26, 2026
| BATT_REQUIRE_OK(this->art_index_.insert(key, inserter)); | ||
| BATT_CHECK_NOT_NULLPTR(inserter.entry_out); | ||
|
|
||
| return inserter.entry_out->edit_offset() + |
Collaborator
There was a problem hiding this comment.
Data race: we should add a data member edit_offset_out(either edit_offset_upper_bound_out or Interval<EditOffset> edit_range_out) to MemTableValueEntryInserter
tonyastolfi
reviewed
May 26, 2026
| } | ||
| }(); | ||
|
|
||
| this->sync_upper_bound_.close(); |
tonyastolfi
reviewed
May 26, 2026
| // Insert this block's slots into the sync upper bound hash map. | ||
| // | ||
| for (usize i = 0; i < next_block->slot_count(); ++i) { | ||
| const i64 slot_start = next_block->slot_edit_offset(i).value(); |
Collaborator
There was a problem hiding this comment.
We can use ChangeLogBlock::edit_offset_range() here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.