Skip to content

Fix data branch decimal results on main#24894

Open
gouhongshen wants to merge 4 commits into
matrixorigin:mainfrom
gouhongshen:codex/fix-data-branch-decimal-main
Open

Fix data branch decimal results on main#24894
gouhongshen wants to merge 4 commits into
matrixorigin:mainfrom
gouhongshen:codex/fix-data-branch-decimal-main

Conversation

@gouhongshen

@gouhongshen gouhongshen commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #24847

What this PR does / why we need it:

Port the data branch decimal result conversion fix to main.

  • Preserve decimal precision/scale metadata from MySQL result columns and validate invalid/missing decimal metadata.
  • Materialize decimal64/decimal128/decimal256 row values as typed MatrixOne vectors when building data branch output batches.
  • Decode and compare decimal256 raw tuple values in data branch hashdiff/change replay paths.
  • Add focused unit tests and BVT coverage with diff_14.sql for decimal64/decimal128/decimal256 data branch diff.

Notes:

Checks:

  • make -C thirdparties
  • source $HOME/.zshrc && moenv && go test ./pkg/container/types ./pkg/frontend ./pkg/vm/engine/disttae/logtailreplay
  • git diff --check upstream/main...HEAD

Draft until CI confirms this port on main.

@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label Jun 9, 2026
@gouhongshen gouhongshen changed the title [codex] Fix data branch decimal results on main Fix data branch decimal results on main Jun 9, 2026
@gouhongshen gouhongshen force-pushed the codex/fix-data-branch-decimal-main branch from 53ecf84 to 0903902 Compare June 10, 2026 02:54
@matrix-meow matrix-meow added size/L Denotes a PR that changes [500,999] lines and removed size/M Denotes a PR that changes [100,499] lines labels Jun 10, 2026
@mergify mergify Bot added kind/bug Something isn't working kind/test-ci labels Jun 10, 2026
@gouhongshen gouhongshen marked this pull request as ready for review June 10, 2026 10:12
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working kind/test-ci size/L Denotes a PR that changes [500,999] lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants