fix(plan): dedup update from source matches (cherry-pick #24932)#24934
Open
ck89119 wants to merge 2 commits into
Open
fix(plan): dedup update from source matches (cherry-pick #24932)#24934ck89119 wants to merge 2 commits into
ck89119 wants to merge 2 commits into
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #23137
What this PR does / why we need it:
Cherry-pick of #24932 to
3.0-dev.This PR fixes the PostgreSQL-style
UPDATE ... SET ... FROM ... WHERE ...path when duplicate source rows match the same target row on tables without FK constraints.The new UPDATE path previously fed duplicate joined rows directly into the update pipeline, which could materialize duplicate primary-key rows for one target row. This change adds a planner-side dedup step for
UPDATE ... FROM: group by the target row's original columns and useany_value()for updated columns, matching the existing fallback path behavior.3.0-dev adaptation:
SpillMemfield initialization from the new AGG node because3.0-devdoes not haveplan.Node.SpillMemorQueryBuilder.aggSpillMem.Tested with:
git diff --checkgo test ./pkg/sql/plan -run TestUpdatePgStyleFromDedupsDuplicateSourceMatchesOnNewPath -count=1