Skip to content

Update build tooling from starter template and fix linter issues#964

Merged
hanzei merged 6 commits intomasterfrom
update-from-starter-template
Feb 17, 2026
Merged

Update build tooling from starter template and fix linter issues#964
hanzei merged 6 commits intomasterfrom
update-from-starter-template

Conversation

@hanzei
Copy link
Contributor

@hanzei hanzei commented Feb 4, 2026 •
edited
Loading

Summary

  • Update Go version from 1.24.6 to 1.25
  • Update golangci-lint to v2.9.0 with new config format (version 2)
  • Update gotestsum to v1.13.0
  • Update Node.js version from 16.13.1 to 20.11
  • Add manifest-check target to Makefile
  • Fix all linter issues to pass make check-style

Changes

Build Tooling

  • Updated .golangci.yml to version 2 format with new linters (bidichk, makezero, modernize, unqueryvet)
  • Updated Makefile with new tool versions and manifest-check target
  • Removed duplicate GO_BUILD_FLAGS from build/setup.mk
  • Added "check" command to build/manifest/main.go

Code Modernization

  • Replaced interface{} with any throughout codebase
  • Replaced custom contains/SliceContainsString functions with slices.Contains
  • Used Go 1.24 features (strings.SplitSeq, fmt.Appendf)
  • Converted if-else chains to tagged switches (QF1003)
  • Simplified embedded field selectors (QF1008: c.Context.Ctx → c.Ctx)
  • Used strings.Builder for efficient string concatenation in loops
  • Applied De Morgan's law simplifications (QF1001)
  • Fixed directory permissions (gosec G301: 0755 → 0750)
  • Added nolint comments for deprecated cipher functions (SA1019)

Config Files

  • Fixed Makefile pattern syntax in .editorconfig
  • Cleaned up duplicate entries in .gitignore

🤖 Generated with Claude Code

@hanzei @claude
Update build tooling from starter template and fix linter issues
bef6288 
- Update Go version from 1.24.6 to 1.24.11
- Update golangci-lint to v2.8.0 with new config format
- Update gotestsum to v1.13.0
- Update Node.js version from 16.13.1 to 20.11
- Add manifest-check target to Makefile
- Use Go 1.24 features (strings.SplitSeq, slices.Contains)
- Replace interface{} with any throughout codebase
- Replace custom contains functions with slices.Contains
- Convert if-else chains to tagged switches
- Simplify embedded field selectors (c.Context.Ctx → c.Ctx)
- Use strings.Builder for efficient string concatenation
- Apply De Morgan's law simplifications
- Fix directory permissions (0755 → 0750)
- Add license headers to build files

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@hanzei hanzei requested a review from a team as a code owner February 4, 2026 13:31
nevyangelova
nevyangelova requested changes Feb 5, 2026
View reviewed changes
Copy link
Contributor

@nevyangelova nevyangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hanzei some minor changes. Also I see tests for contains and SliceContainsString were removed but the tests for containsValue in utils_test.go were also removed. Consider keeping at least one integration test to verify the behavior with your specific use cases.

hanzei and others added 2 commits February 13, 2026 10:40
@hanzei @claude
Restore omitempty on DefaultRepo field
deccacb 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@hanzei @claude
Use omitzero instead of omitempty for DefaultRepo struct field
4be60d8 
omitempty has no effect on non-pointer struct fields in JSON encoding.
Go 1.24's omitzero correctly omits the field when the struct is its
zero value.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Feb 13, 2026
@hanzei hanzei mentioned this pull request Feb 13, 2026
Closed
3 tasks
@hanzei
Copy link
Contributor Author

hanzei commented Feb 13, 2026

Also I see tests for contains and SliceContainsString were removed but the tests for containsValue in utils_test.go were also removed. Consider keeping at least one integration test to verify the behavior with your specific use cases.

The code now uses strings.Contains in all places instead of custom code. What is the "specific use cases" we have for that std lib method that would require additonal testing?

@hanzei hanzei requested a review from nevyangelova February 13, 2026 10:03
@nevyangelova
Copy link
Contributor

nevyangelova commented Feb 16, 2026

LGTM please rebase with master for the new .nvmrc version update.

hanzei and others added 3 commits February 17, 2026 09:46
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Feb 17, 2026
@hanzei hanzei modified the milestone: v2.5.0 Feb 17, 2026
@hanzei hanzei merged commit b9c1cc2 into master Feb 17, 2026
11 checks passed
@hanzei hanzei deleted the update-from-starter-template branch February 17, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nevyangelova nevyangelova nevyangelova approved these changes

Assignees

No one assigned

Labels

4: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hanzei @nevyangelova